Skip to content

Commit

Permalink
Update status to accepted
Browse files Browse the repository at this point in the history
  • Loading branch information
rhshadrach committed Feb 16, 2025
1 parent ff0958a commit 1cbf071
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions web/pandas/pdeps/0008-inplace-methods-in-pandas.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# PDEP-8: In-place methods in pandas

- Created: 16 February 2023
- Status: Under discussion
- Status: Accepted
- Discussion: [PR 51466](https://github.com/pandas-dev/pandas/pull/51466)
- Authors: [Thomas Li](https://github.com/lithomas1),
[Patrick Hoefler](https://github.com/phofl),
Expand Down Expand Up @@ -348,7 +348,7 @@ Disadvantages:

We generally assume that changing to return `self` should not give much problems for
existing usage (typically, the current return value of `None` is not actively used).
Further, we think the advantages of simplifing return types and enabling methods chains
Further, we think the advantages of simplifying return types and enabling methods chains
outweighs the special case of returning an identical object.
**Therefore, we propose that for those methods with an `inplace=True` option, the calling object (`self`) gets returned.**

Expand Down

0 comments on commit 1cbf071

Please sign in to comment.