Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gherkin to languages and frameworks #23

Merged
merged 8 commits into from
Dec 13, 2023

Conversation

TommasoLencioni
Copy link
Contributor

  • I've added a short description of the entry that
    clarifies what it does and why it's useful
  • I've added links to the entry's documentation and/or
    website
  • My frontmatter is correct, complete and follows the
    format specified in the README
  • In case the entry is in the adopt category: I've
    added at least one reference to showcase the entry usage
    among our organization
  • I've described at least one use case for the entry

@TommasoLencioni TommasoLencioni requested review from a team as code owners December 5, 2023 15:23
tags: [all]
---

Gherkin is a domain-specific language designed for describing software behavior without detailing how that behavior is implemented. It serves as a collaboration tool between technical and non-technical team members.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd insert at least link to some helpful resource.


### Our use cases:

- [Test automation](https://github.com/pagopa/idpay-functional-testing)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this IDPay specific or it's used also in other products?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked repo is IDPay specific, being the only place where Gherkin is used by CSTAR team.
As far as i can tell Gherkin is also used in other products:
https://github.com/pagopa/pagopa-taxonomy
https://github.com/pagopa/pagopa-nodo-dei-pagamenti-test
https://github.com/pagopa/pagopa-fdr


- **Tool Agnostic**

### Our use cases:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand a litttle bit? ie. when it is supposed to be used, in unit tests or integration tests as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expanded all the sections, please check them out and let me know, thank you! 😄

@gunzip
Copy link
Contributor

gunzip commented Dec 12, 2023

The entry is well-composed. However, I have reservations about including it in the 'adopt' quadrant. This classification typically implies widespread use of the technology across different teams, which may not yet be the case yet. Let's see if someone between CODEOWNERs pushes the button :-)

@lucacavallaro
Copy link
Member

I propose to change the ring from adopt to trial

When Gherkin will be used outside idpay we can move it to adopt

@iwoak
Copy link
Contributor

iwoak commented Dec 12, 2023

@lucacavallaro I was thinking the same thing but then I made this query https://github.com/search?q=org%3Apagopa+language%3AGherkin&type=code
pagoPA, idpay, interop, pn :O

@GiovanniMancini @pasqualespica @infantesimone does you confirm? are you using with satisfaction Gherkin?

@lucacavallaro
Copy link
Member

@iwoak ok, do you filtered out the contributions made by consultants? they often bring into our stack their technologies, but then we do not adopt them

@iwoak
Copy link
Contributor

iwoak commented Dec 12, 2023

@lucacavallaro nope, but I asked to the internal member of those products whether it was our conscious choice.

@ruggerocastagnola I noticed that you and your team used it, feedback?

@ZorbaDimatteo
Copy link

joining the discussion: in pn we use gherkin (proposed by consultant but adopted by team) because it's easier for our QA team to write and discuss test cases with developers, but also to analyze the results of e2e automatic tests more easily

@gunzip
Copy link
Contributor

gunzip commented Dec 12, 2023

@ZorbaDimatteo may you share a link to PN repo(s) pointing to tests?

@ZorbaDimatteo
Copy link

@gunzip sure!
here they are
https://github.com/pagopa/pn-b2b-client
https://github.com/pagopa/pn-frontend-e2e

Copy link
Contributor

@balanza balanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the entry, thanks @TommasoLencioni

I propose just a couple of possible, optional refinements, if you find them useful:

  1. review the list of repositories that use gherkin
  2. differentiate "use cases" (a list of scenario in which we suggest Gherkin to be an proper solution) from "actual usage" (the list of using repos); this should help readers fit Gherkin in their solutions

@gunzip
Copy link
Contributor

gunzip commented Dec 12, 2023

I've added the link provided by @iwoak that lists all repos that use Gherkin.

I'd vote to merge this one as is, then refine the entry according to:

differentiate "use cases" (a list of scenario in which we suggest Gherkin to be an proper solution) from "actual usage" (the list of using repos); this should help readers fit Gherkin in their solutions

@gunzip gunzip merged commit 9284de0 into pagopa:main Dec 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants