-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gherkin to languages and frameworks #23
Conversation
tags: [all] | ||
--- | ||
|
||
Gherkin is a domain-specific language designed for describing software behavior without detailing how that behavior is implemented. It serves as a collaboration tool between technical and non-technical team members. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd insert at least link to some helpful resource.
|
||
### Our use cases: | ||
|
||
- [Test automation](https://github.com/pagopa/idpay-functional-testing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this IDPay specific or it's used also in other products?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linked repo is IDPay specific, being the only place where Gherkin is used by CSTAR team.
As far as i can tell Gherkin is also used in other products:
https://github.com/pagopa/pagopa-taxonomy
https://github.com/pagopa/pagopa-nodo-dei-pagamenti-test
https://github.com/pagopa/pagopa-fdr
|
||
- **Tool Agnostic** | ||
|
||
### Our use cases: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you expand a litttle bit? ie. when it is supposed to be used, in unit tests or integration tests as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expanded all the sections, please check them out and let me know, thank you! 😄
The entry is well-composed. However, I have reservations about including it in the 'adopt' quadrant. This classification typically implies widespread use of the technology across different teams, which may not yet be the case yet. Let's see if someone between CODEOWNERs pushes the button :-) |
I propose to change the When Gherkin will be used outside |
@lucacavallaro I was thinking the same thing but then I made this query https://github.com/search?q=org%3Apagopa+language%3AGherkin&type=code @GiovanniMancini @pasqualespica @infantesimone does you confirm? are you using with satisfaction Gherkin? |
@iwoak ok, do you filtered out the contributions made by consultants? they often bring into our stack their technologies, but then we do not adopt them |
@lucacavallaro nope, but I asked to the internal member of those products whether it was our conscious choice. @ruggerocastagnola I noticed that you and your team used it, feedback? |
joining the discussion: in pn we use gherkin (proposed by consultant but adopted by team) because it's easier for our QA team to write and discuss test cases with developers, but also to analyze the results of e2e automatic tests more easily |
@ZorbaDimatteo may you share a link to PN repo(s) pointing to tests? |
@gunzip sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the entry, thanks @TommasoLencioni
I propose just a couple of possible, optional refinements, if you find them useful:
- review the list of repositories that use gherkin
- differentiate "use cases" (a list of scenario in which we suggest Gherkin to be an proper solution) from "actual usage" (the list of using repos); this should help readers fit Gherkin in their solutions
I've added the link provided by @iwoak that lists all repos that use Gherkin. I'd vote to merge this one as is, then refine the entry according to:
|
clarifies what it does and why it's useful
website
format specified in the README
adopt
category: I'veadded at least one reference to showcase the entry usage
among our organization