Don't defer redirects

pagefaultgames · Jul 28, 2024 · ed8122c · ed8122c
1 parent 611a0e3
commit ed8122c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/api/account/discord.go b/api/account/discord.go
@@ -33,13 +33,13 @@ var (
 func HandleDiscordCallback(w http.ResponseWriter, r *http.Request) (string, error) {
 	code := r.URL.Query().Get("code")
 	if code == "" {
-		defer http.Redirect(w, r, GameURL, http.StatusSeeOther)
+		http.Redirect(w, r, GameURL, http.StatusSeeOther)
 		return "", errors.New("code is empty")
 	}
 
 	discordId, err := RetrieveDiscordId(code)
 	if err != nil {
-		defer http.Redirect(w, r, GameURL, http.StatusSeeOther)
+		http.Redirect(w, r, GameURL, http.StatusSeeOther)
 		return "", err
 	}
 

diff --git a/api/account/google.go b/api/account/google.go
@@ -35,13 +35,13 @@ var (
 func HandleGoogleCallback(w http.ResponseWriter, r *http.Request) (string, error) {
 	code := r.URL.Query().Get("code")
 	if code == "" {
-		defer http.Redirect(w, r, GameURL, http.StatusSeeOther)
+		http.Redirect(w, r, GameURL, http.StatusSeeOther)
 		return "", errors.New("code is empty")
 	}
 
 	googleId, err := RetrieveGoogleId(code)
 	if err != nil {
-		defer http.Redirect(w, r, GameURL, http.StatusSeeOther)
+		http.Redirect(w, r, GameURL, http.StatusSeeOther)
 		return "", err
 	}
 

diff --git a/api/endpoints.go b/api/endpoints.go
@@ -635,7 +635,7 @@ func handleProviderCallback(w http.ResponseWriter, r *http.Request) {
 		})
 	}
 
-	defer http.Redirect(w, r, account.GameURL, http.StatusSeeOther)
+	http.Redirect(w, r, account.GameURL, http.StatusSeeOther)
 }
 
 func handleProviderLogout(w http.ResponseWriter, r *http.Request) {
-Original file line number
+Diff line change
@@ Expand Up @@
     		})
     	}
-    	defer http.Redirect(w, r, account.GameURL, http.StatusSeeOther)
+    	http.Redirect(w, r, account.GameURL, http.StatusSeeOther)
     }
     func handleProviderLogout(w http.ResponseWriter, r *http.Request) {
@@ Expand Down @@