feat(semantic): memoize Bindings hashmap's key hash (POC)
#8622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-linter
Boshen
force-pushed
the
01-20-feat_semantic_memoize_bindings_hashmap_s_key_hash
branch
from
3beeef1 to
df169ec
Compare
Boshen
force-pushed
the
01-20-feat_semantic_memoize_bindings_hashmap_s_key_hash
branch
from
df169ec to
9fa1d6b
Compare
Boshen
commented
Jan 20, 2025
| self.cell.with_dependent_mut(|_allocator, inner| { | ||
| inner.bindings[scope_id].remove(name); | ||
| self.cell.with_dependent_mut(|allocator, inner| { | ||
| let key = Key::new(allocator.alloc_str(name)); |
There was a problem hiding this comment.
This is wasteful, need to use the entry API instead.
CodSpeed Performance ReportMerging #8622 will not alter performanceComparing Summary
|
|
Only 2%? |
Boshen
deleted the
01-20-feat_semantic_memoize_bindings_hashmap_s_key_hash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to reduce the total number of hashes here
oxc/crates/oxc_semantic/src/builder.rs
Line 490 in 6f95cd5
This is a dump of code with no intention of being merged.