Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] added test to share resources concurrently to federated user #11039

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Feb 20, 2025

Description

This PR adds the tests for sharing resources concurrently to federated users.

  • sharing multiple resources to a single federated user
  • sharing multiple resources to multiple federated users

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PrajwolAmatya PrajwolAmatya self-assigned this Feb 20, 2025
@PrajwolAmatya PrajwolAmatya force-pushed the test-concurrent-ocm-sharing branch 3 times, most recently from 2a1df28 to 09b93d6 Compare February 27, 2025 07:13
@PrajwolAmatya PrajwolAmatya force-pushed the test-concurrent-ocm-sharing branch from 09b93d6 to 6d43a0a Compare March 4, 2025 06:51
@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review March 4, 2025 08:15
@PrajwolAmatya PrajwolAmatya force-pushed the test-concurrent-ocm-sharing branch 3 times, most recently from ef32f48 to fe4996e Compare March 5, 2025 06:49
@PrajwolAmatya PrajwolAmatya force-pushed the test-concurrent-ocm-sharing branch from fe4996e to b876b75 Compare March 6, 2025 06:57
@PrajwolAmatya PrajwolAmatya force-pushed the test-concurrent-ocm-sharing branch from b876b75 to 36d38e8 Compare March 10, 2025 03:27
Comment on lines +1412 to +1413
| resource | folderToShare1 |
| permissionsRole | Viewer |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do something like this

Suggested change
| resource | folderToShare1 |
| permissionsRole | Viewer |
| resource | permissionsRole |
| folderToShare1 | Viewer |
| folderToShare2 | Editor |
| folderToShare1 | Viewer |
...

Comment on lines +1411 to +1413
And user "Brian" should have the following federated share shared by user "Alice"
| resource | folderToShare1 |
| permissionsRole | Viewer |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And user "Brian" should have the following federated share shared by user "Alice"
| resource | folderToShare1 |
| permissionsRole | Viewer |
And user "Brian" should have the following federated shares:
| resource | permissionsRole | sharer |
| folderToShare1 | Viewer | Alice |
| folderToShare2 | Editor | Alice |
| folderToShare1 | Viewer | Alice |

| folderToShare2 |
And user "Alice" has uploaded file with content "some content" to "textfile1.txt"
And user "Alice" has uploaded file with content "hello world" to "textfile2.txt"
When user "Alice" sends the following resources share invitation concurrently to federated user using the Graph API:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When user "Alice" sends the following resources share invitation concurrently to federated user using the Graph API:
When user "Alice" sends the following concurrent resource share invitations to federated user using the Graph API:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants