Add important documentation on the async nature of Vfs::startImpl()
#12078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to inform/warn VFS implementors of the fact that starting the VFS implementation is assumed to possibly start in the background. But more importantly: the client will not "wait" for one VFS instance to be started before calling `start` on a second instance. Meaning: synchronization (when needed) has to be done by the VFS impementation itself.
erikjv
added
Windows
feature:vfs
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
modSpike
approved these changes
Feb 24, 2025
DeepDiver1975
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to inform/warn VFS implementors of the fact that starting the VFS implementation is assumed to possibly start in the background. But more importantly: the client will not "wait" for one VFS instance to be started before calling
starton a second instance. Meaning: synchronization (when needed) has to be done by the VFS impementation itself.