Add catalogPath to mdims #4576
Open
Add catalogPath to mdims #4576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rakyi
commented
Feb 19, 2025
Comment on lines
+392
to
+396
| await deleteGrapherConfigFromR2( | ||
| R2GrapherConfigDirectory.multiDim, | ||
| `${multiDim.slug}.json` | ||
| ) | ||
| await retrieveMultiDimConfigFromDbAndSaveToR2(knex, multiDim.id) |
There was a problem hiding this comment.
Not related to catalog path, I just forgot to do this in the previous PR.
rakyi
force-pushed
the
mdim-catalog-path
branch
2 times, most recently
from
b6d81b2 to
b87e787
Compare
rakyi
changed the base branch from
remove-mdim-feature-flag
to
graphite-base/4576
rakyi
force-pushed
the
graphite-base/4576
branch
from
e36a891 to
0306200
Compare
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-02-19 11:18:04 UTC |
* Catalog path will now be the main ID used by ETL
* It's temporarily allowed to be null; we'll disallow that once existing
data is migrated
* Slug is now allowed to be null, since it will be only set in admin at
some point
* For that reason we'll use the catalog path as a slug for previews of
mdims in the admin, i.e. `/admin/grapher/{catalogPath}`
rakyi
force-pushed
the
mdim-catalog-path
branch
from
b87e787 to
16b157f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data is migrated
some point
mdims in the admin, i.e.
/admin/grapher/{catalogPath}