🎉 share newly created DIs in Slack #4571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2025
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-02-18 11:48:32 UTC |
sophiamersmann
changed the title
sophiamersmann
force-pushed
the
create-di-topic-tags
branch
from
55f09da to
b8da097
Compare
sophiamersmann
force-pushed
the
share-di-in-slack
branch
from
468c34e to
c1249cf
Compare
sophiamersmann
force-pushed
the
create-di-topic-tags
branch
from
b8da097 to
7d78a3e
Compare
sophiamersmann
force-pushed
the
share-di-in-slack
branch
from
c1249cf to
3d4609d
Compare
ikesau
approved these changes
Feb 20, 2025
|
|
||
| const response = await fetch(url, fetchData) | ||
|
|
||
| if (!response.ok) { |
There was a problem hiding this comment.
I don't think there's anything we can do to catch this, but the request was 200'ing for me, but not posting to slack when I put zalgo text in it.
I don't think that'll be something we have to worry about from our authors though 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send a message to the
#data-insights-pitcheschannel in Slack on DI creation.The Slack message includes the title, an optional note and the image (see screenshot).
The idea of having a
#data-insights-pitcheschannel is that there is a very early editorial review that decides whether it makes sense to flesh out a data insight.For testing, set
SLACK_DI_PITCHES_CHANNEL_IDto the ID of the#data-insights-pitcheschannel (I just added you to the channel). The secret key forSLACK_BOT_OAUTH_TOKENis in 1password.The env var isn't set on staging yet, so it's currently only testable locally. I'll figure this out tomorrow, but I wanted to open up for review anyway.
Screenshot
This is part 9 of 9 in a stack made with GitButler: