-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add data page metadata fields to admin #3006
✨ add data page metadata fields to admin #3006
Conversation
555e54f
to
2e817b6
Compare
2e817b6
to
a44ccfa
Compare
@danyx23 added sources to indicator and dataset admin pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think we should probably add a limit clause to the sources query for datasets. The reason is that for some extreme datasets there are hundreds or thousands of sources. Maybe limit it to 50 and add a note above or below the list?
I also removed the singular source on datasets as we no longer need it there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should limit the number of sources we retrieve, otherwise this is good to ship!
Implementation of #2523.
Indicator page
updatePeriodDays
Dataset page
origins
toadmin/api/datasets/X.json
updatePeriodDays
Notes
secondaryLabel
, but eventually decided to only include link to our docs as the help would get outdated soonExamples: