chore: disregard branch in commit finder #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
|
We should be able to remove the branch and commit hash for the Can you please change the corresponding test? |
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
benmss
changed the title
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
benmss
force-pushed
the
585-commit-finder-branch-unavailable
branch
from
4906bcd to
5cec585
Compare
nathanwn
reviewed
Jan 3, 2024
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
|
The PR title probably needs to be updated, with the issue number at the end and the description a bit more elaborate. Probably something like this, but just my suggestion: Otherwise, I think it's LGTM. |
nathanwn
approved these changes
Jan 4, 2024
benmss
changed the title
behnazh-w
reviewed
Jan 4, 2024
benmss
changed the title
benmss
changed the title
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
behnazh-w
approved these changes
Jan 8, 2024
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in some cases the branch for a commit found by the commit finder cannot also be found, and that branches are not needed to pull a commit, this PR removes all attempts at retrieving branch information as part of the commit finding process. This makes the commit finder return only a commit hash/digest.
Closes #585