[GR-62126] Reverse dependency between svm core and svm configure projects. #10905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is best reviewed commit-by-commit (though builds between commits likely do not work; this was a large change and my goal was to make it reviewable).
In order to do tracing from a native image,
coreneeds access toConfigurationSetand related classes. On master,configuredepends oncore, which prevents us from adding a dependency in the other direction. This change refactors the projects to break the dependency and adds a dependency fromcoretoconfigure.Essentially:
coreandconfigure, we move it fromcom.oracle.svm.core.*tocom.oracle.svm.configure(e.g.,com.oracle.svm.core.configure.ConfigurationFile -> com.oracle.svm.configure.ConfigurationFile).com.oracle.svm.util(e.g.,TypeResult).I had to also extract some logic out of core if a class could not be wholesale moved (e.g.,
NativeImageResourcePathRepresentation,GlobUtils).There were also some places that configure was depending on hosted options like
TreatAllTypeReachableConditionsAsTypeReached; I have removed those accesses and instead require the flag to be supplied as a parameter.