-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow-up #926: Add the test for jupyterlab exntension build #969
Follow-up #926: Add the test for jupyterlab exntension build #969
Conversation
c679137
to
6f4bff4
Compare
This pull request has not seen any recent activity. |
This pull request was closed automatically because it had not seen any recent activity. If you want to discuss it, you can reopen it freely. |
277f14d
to
b672f26
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
=======================================
Coverage 70.00% 70.00%
=======================================
Files 35 35
Lines 2387 2387
=======================================
Hits 1671 1671
Misses 716 716 ☔ View full report in Codecov by Sentry. |
999cd98
to
c39461d
Compare
c39461d
to
6e559a1
Compare
426db1f
to
6e559a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I have confirmed that the builds for tslib
(types, storage, react), standalone_app
, optuna_dashboard
, and vscode
are successful and that there are no incorrect behaviors.
For jupyterlab
, I verified that running jupyter lab
works with:
- the version installed via
pip install -e .
- the version installed via locally built sdist
However, it seems jlpm build
command mentioned in jupyterlab/README.md
does not work as expected for now. This will likely require a follow-up to address the issue later.
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
Refs #926
What does this implement/fix? Explain your changes.
Fix the build error of the jupyter lab extension.