Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up #926: Add the test for jupyterlab exntension build #969

Merged
merged 8 commits into from
Jan 15, 2025

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Sep 19, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

Refs #926

What does this implement/fix? Explain your changes.

Fix the build error of the jupyter lab extension.

@c-bata c-bata force-pushed the feat/test-for-jupyterlab-extension branch from c679137 to 6f4bff4 Compare September 19, 2024 08:03
@c-bata c-bata closed this Sep 19, 2024
@c-bata c-bata reopened this Sep 19, 2024
Copy link

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale for stale bot label Nov 18, 2024
Copy link

This pull request was closed automatically because it had not seen any recent activity. If you want to discuss it, you can reopen it freely.

@github-actions github-actions bot closed this Nov 25, 2024
@c-bata c-bata reopened this Nov 29, 2024
@github-actions github-actions bot removed the stale for stale bot label Dec 1, 2024
@c-bata c-bata force-pushed the feat/test-for-jupyterlab-extension branch 3 times, most recently from 277f14d to b672f26 Compare January 9, 2025 11:27
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.00%. Comparing base (6e5ddc7) to head (999cd98).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #969   +/-   ##
=======================================
  Coverage   70.00%   70.00%           
=======================================
  Files          35       35           
  Lines        2387     2387           
=======================================
  Hits         1671     1671           
  Misses        716      716           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-bata c-bata force-pushed the feat/test-for-jupyterlab-extension branch from 999cd98 to c39461d Compare January 14, 2025 04:26
@c-bata c-bata force-pushed the feat/test-for-jupyterlab-extension branch from c39461d to 6e559a1 Compare January 14, 2025 05:04
@c-bata c-bata marked this pull request as ready for review January 14, 2025 06:04
@c-bata c-bata force-pushed the feat/test-for-jupyterlab-extension branch from 426db1f to 6e559a1 Compare January 14, 2025 07:17
Copy link
Collaborator

@porink0424 porink0424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I have confirmed that the builds for tslib (types, storage, react), standalone_app, optuna_dashboard, and vscode are successful and that there are no incorrect behaviors.

For jupyterlab, I verified that running jupyter lab works with:

  • the version installed via pip install -e .
  • the version installed via locally built sdist

However, it seems jlpm build command mentioned in jupyterlab/README.md does not work as expected for now. This will likely require a follow-up to address the issue later.

@porink0424 porink0424 removed their assignment Jan 15, 2025
@c-bata c-bata merged commit 68957a5 into optuna:main Jan 15, 2025
21 checks passed
@c-bata c-bata deleted the feat/test-for-jupyterlab-extension branch January 15, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants