Change requirements to optuna>=3.1.0 #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
=======================================
Coverage 69.48% 69.48%
=======================================
Files 35 35
Lines 2353 2353
=======================================
Hits 1635 1635
Misses 718 718 ☔ View full report in Codecov by Sentry. |
c-bata
reviewed
Jan 11, 2024
.github/workflows/python-tests.yml
Outdated
Comment on lines
35
to
36
| # Add Python '3.11' after released Optuna v3.1 | ||
| # since Optuna v3.0.4 depends on scipy<1.9.0 and >=1.7.0 |
.github/workflows/python-tests.yml
Outdated
| @@ -34,37 +34,22 @@ jobs: | |||
| matrix: | |||
| # Add Python '3.11' after released Optuna v3.1 | |||
| # since Optuna v3.0.4 depends on scipy<1.9.0 and >=1.7.0 | |||
| python-version: ['3.7', '3.8', '3.9', '3.10'] | |||
| python-version: ['3.7', '3.8', '3.9', '3.10', '3.11'] | |||
| optuna-version: ['optuna>=3.1.0', 'git+https://github.com/optuna/optuna.git'] | |||
There was a problem hiding this comment.
I would suggest that there's no need to run unit tests with Optuna's master branch and Python versions 3.7-3.10. Could you skip these cases?
c-bata
reviewed
Jan 11, 2024
.github/workflows/python-tests.yml
Outdated
| @@ -21,7 +21,7 @@ jobs: | |||
| # python_tests requires optuna>=3.0.0 since it imports FloatDistribution | |||
Skip artifact tests Fix error Fix error Fix error Fix error Fix error
keisuke-umezawa
force-pushed
the
feature/deprecate-optuna-v2
branch
from
12a2171 to
db6dcab
Compare
c-bata
approved these changes
Jan 23, 2024
Co-authored-by: c-bata <c-bata@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
NA
What does this implement/fix? Explain your changes.
Change requirements to optuna>=3.1.0