Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the vscode extension's entry point for code-server execution #741

Conversation

HideakiImamura
Copy link
Member

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Motivations

The current VS Code extension does not support code-server. This PR aims to fix it.

Details of the change

According to the documentation, the VS Code extension for the code-server must not be the web extension. The current entry point is defined by browser property, which is for the web extension. I changed the property name from the browser to the main, which is for the standard extension.

How to confirm the change

  1. Create the VSIX file by running make vscode-extension.
  2. Upload the VSIX file to the remote environment running the code-server.
  3. Install the extension from the VSIX file. Right click the file, and press the Install Extension VSIX.
  4. Open some sqlite file by right clicking and press the Open in Optuna Dashboard.

Sorry, something went wrong.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (1203501) 68.22% compared to head (8fcbaf5) 68.22%.
Report is 196 commits behind head on main.

Files Patch % Lines
optuna_dashboard/artifact/_backend.py 31.42% 24 Missing ⚠️
optuna_dashboard/_app.py 94.59% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #741   +/-   ##
=======================================
  Coverage   68.22%   68.22%           
=======================================
  Files          35       35           
  Lines        2329     2329           
=======================================
  Hits         1589     1589           
  Misses        740      740           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-bata c-bata self-assigned this Jan 9, 2024
@c-bata
Copy link
Member

c-bata commented Jan 11, 2024

@HideakiImamura Thank you for your pull request.
I confirmed that this PR makes it being able to open the sqlite file. However, no studies are shown in my environment although I created some studies in the file. Is this problem reproducible in your environment?

Screenshot 2024-01-11 19 17 37

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why but now I can see that the extension works perfect. Thank you for your pull request!

Screenshot 2024-01-12 10 09 05

@c-bata c-bata mentioned this pull request Jan 12, 2024
1 task
c-bata added a commit that referenced this pull request Jan 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…scode-extension

Fixes the file conflict for #741
@c-bata c-bata merged commit 5c2bc4a into optuna:main Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants