-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve: dependent resources notify all owners by default #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Dec 14, 2023
Will add integration test before merged. |
csviri
force-pushed
the
k8s-dependent-multiowner
branch
from
December 19, 2023 13:10
d52ffbf
to
cf9da80
Compare
csviri
force-pushed
the
k8s-dependent-multiowner
branch
from
December 19, 2023 13:13
cf9da80
to
011c22c
Compare
This looks like it needs to be rebased. |
csviri
force-pushed
the
k8s-dependent-multiowner
branch
from
December 21, 2023 09:45
219ef27
to
8e95a78
Compare
openshift-merge-robot
added
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Dec 28, 2023
csviri
force-pushed
the
k8s-dependent-multiowner
branch
from
January 8, 2024 11:30
8e95a78
to
dcb37a3
Compare
openshift-merge-robot
removed
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Jan 8, 2024
csviri
force-pushed
the
k8s-dependent-multiowner
branch
from
January 8, 2024 11:56
dcb37a3
to
be410c2
Compare
openshift-merge-robot
added
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Jan 8, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
This allows multiple threads to wait on an informers to start in an idempotent and thread-safe way Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
force-pushed
the
k8s-dependent-multiowner
branch
from
January 8, 2024 13:12
be410c2
to
32c52ad
Compare
openshift-merge-robot
removed
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Jan 8, 2024
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Jan 8, 2024
metacosm
approved these changes
Jan 9, 2024
csviri
added a commit
that referenced
this pull request
Jan 10, 2024
* improve: dependent resources notify all owners by default Signed-off-by: Attila Mészáros <csviri@gmail.com> * improve: idempotent thread-safe start This allows multiple threads to wait on an informers to start in an idempotent and thread-safe way Signed-off-by: Attila Mészáros <csviri@gmail.com> * revert start stop synx Signed-off-by: Attila Mészáros <csviri@gmail.com> * fix IT Signed-off-by: Attila Mészáros <csviri@gmail.com> --------- Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
added a commit
that referenced
this pull request
Jan 10, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
added a commit
that referenced
this pull request
Jan 10, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.