Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: dependent resources notify all owners by default #2161

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Dec 14, 2023

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2023
@csviri
Copy link
Collaborator Author

csviri commented Dec 14, 2023

Will add integration test before merged.

@csviri csviri requested a review from metacosm December 14, 2023 13:09
@csviri csviri force-pushed the k8s-dependent-multiowner branch from d52ffbf to cf9da80 Compare December 19, 2023 13:10
@csviri csviri added this to the 4.7 milestone Dec 19, 2023
@csviri csviri force-pushed the k8s-dependent-multiowner branch from cf9da80 to 011c22c Compare December 19, 2023 13:13
@csviri csviri self-assigned this Dec 19, 2023
@metacosm
Copy link
Collaborator

This looks like it needs to be rebased.

@csviri csviri force-pushed the k8s-dependent-multiowner branch from 219ef27 to 8e95a78 Compare December 21, 2023 09:45
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 28, 2023
@csviri csviri force-pushed the k8s-dependent-multiowner branch from 8e95a78 to dcb37a3 Compare January 8, 2024 11:30
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2024
@csviri csviri force-pushed the k8s-dependent-multiowner branch from dcb37a3 to be410c2 Compare January 8, 2024 11:56
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2024
@csviri csviri changed the base branch from main to next January 8, 2024 11:56
csviri added 3 commits January 8, 2024 14:12
Signed-off-by: Attila Mészáros <csviri@gmail.com>
This allows multiple threads to wait on an informers to start in an idempotent and thread-safe way

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri force-pushed the k8s-dependent-multiowner branch from be410c2 to 32c52ad Compare January 8, 2024 13:12
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri marked this pull request as ready for review January 8, 2024 14:10
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
@openshift-ci openshift-ci bot requested review from adam-sandor and andreaTP January 8, 2024 14:10
@csviri csviri merged commit d0eb3ad into next Jan 10, 2024
22 checks passed
@csviri csviri deleted the k8s-dependent-multiowner branch January 10, 2024 07:56
csviri added a commit that referenced this pull request Jan 10, 2024
* improve: dependent resources notify all owners by default

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* improve: idempotent thread-safe start

This allows multiple threads to wait on an informers to start in an idempotent and thread-safe way

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* revert start stop synx

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* fix IT

Signed-off-by: Attila Mészáros <csviri@gmail.com>

---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Jan 10, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Jan 10, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Primary to DR many-to-one & many-to-many relationships possible?
3 participants