Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strongswan: DHCP on lo fixes backport #25870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lowjoel
Copy link
Contributor

@lowjoel lowjoel commented Jan 31, 2025

Fixes #25801. Adds the following commits to fix DHCP behaviour on Strongswan 5.9.14:

Maintainer: @pprindeville
Compile tested: aarch64 Linksys E8450 master
Run tested: aarch64 Linksys E8450 OpenWrt 24.10-rc6

Description:

Backports DHCP listening patches from Strongswan when the DHCP server is on lo. Please also backport this to OpenWrt 24.10 (23.05 is unaffected).

@lowjoel lowjoel force-pushed the patch-strongswan-dhcp branch 2 times, most recently from d2ea708 to 57e9594 Compare February 1, 2025 01:38
@lowjoel
Copy link
Contributor Author

lowjoel commented Feb 1, 2025

2025-02-01T02:00:35.4553648Z In file included from /builder/staging_dir/target-aarch64_generic_musl/usr/include/wolfssl/ssl.h:35,
2025-02-01T02:00:35.4554495Z                  from wolfssl_plugin.c:48:
2025-02-01T02:00:35.4555507Z /builder/staging_dir/target-aarch64_generic_musl/usr/include/wolfssl/error-ssl.h:56:5: error: redeclaration of enumerator 'PARSE_ERROR'
2025-02-01T02:00:35.4556594Z    56 |     PARSE_ERROR                  = -306,   /* parse error on header    */
2025-02-01T02:00:35.4557104Z       |     ^~~~~~~~~~~
2025-02-01T02:00:35.4557567Z In file included from ../../../../src/libstrongswan/utils/utils.h:59,
2025-02-01T02:00:35.4558186Z                  from ../../../../src/libstrongswan/library.h:102,
2025-02-01T02:00:35.4558669Z                  from wolfssl_common.h:28,
2025-02-01T02:00:35.4559091Z                  from wolfssl_plugin.c:24:
2025-02-01T02:00:35.4559940Z ../../../../src/libstrongswan/utils/utils/status.h:47:9: note: previous definition of 'PARSE_ERROR' with type 'enum status_t'
2025-02-01T02:00:35.4560789Z    47 |         PARSE_ERROR,
2025-02-01T02:00:35.4561363Z       |         ^~~~~~~~~~~

Hmm, not sure if this was introduced elsewhere in main?

@divinehawk
Copy link
Contributor

2025-02-01T02:00:35.4560789Z    47 |         PARSE_ERROR,
2025-02-01T02:00:35.4561363Z       |         ^~~~~~~~~~~

Hmm, not sure if this was introduced elsewhere in main?

Wolfssl was updated to a newer version, requiring another backport. #25878

Fixes openwrt#25801. Adds the following commits to fix DHCP behaviour on
Strongswan 5.9.14:

 - strongswan/strongswan@abbf9d2
 - strongswan/strongswan@00d8c36
 - strongswan/strongswan@a50ed30

Signed-off-by: Joel Low <joel@joelsplace.sg>
@lowjoel lowjoel force-pushed the patch-strongswan-dhcp branch from 4876176 to 62a6165 Compare February 3, 2025 23:22
@lowjoel
Copy link
Contributor Author

lowjoel commented Feb 4, 2025

@Thermi sorry, would you also be able to review this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strongswan: dhcp plugin not issuing addresses to clients after upgrading to 24.10-rc4
2 participants