Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-cloudflared: Overhaul tunnels.js #6943

Merged
merged 3 commits into from
Feb 27, 2024
Merged

luci-app-cloudflared: Overhaul tunnels.js #6943

merged 3 commits into from
Feb 27, 2024

Conversation

animegasan
Copy link
Contributor

I overhauled tunnels.js to make it more organized. And upgraded it to version 1.2

Some changes are:

  1. Make data from tunnel into a table
  2. Add a class for the table structure
  3. Wrap each table with a class section

Before

image

After

image

Signed-off-by: Hilman Maulana <hilman0.0maulana@gmail.com>
Signed-off-by: Hilman Maulana <hilman0.0maulana@gmail.com>
Signed-off-by: Hilman Maulana <hilman0.0maulana@gmail.com>
@systemcrash
Copy link
Contributor

OK. Thanks.

In future avoid PR from your master branch - it gets messy when you need to rebase on the current master.

@systemcrash systemcrash merged commit 6200371 into openwrt:master Feb 27, 2024
4 of 5 checks passed
@hnyman
Copy link
Contributor

hnyman commented Mar 1, 2024

This contains obvious duplicates (at least one). Weblate complaints about that.
I will remove them.
The new translation keys were not added into the proper places alphabetically, so let's fix also that...

Example duplicate, added just before the already existing identical msgid:

+#: applications/luci-app-cloudflared/htdocs/luci-static/resources/view/cloudflared/tunnels.js:54
+msgid "Connections"
+msgstr ""
+
+#: applications/luci-app-cloudflared/htdocs/luci-static/resources/view/cloudflared/tunnels.js:90
 msgid "Connections"
 msgstr ""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants