Skip to content

Commit

Permalink
luci-app-firewall: follow-up fix to reuse previous i18n strings
Browse files Browse the repository at this point in the history 
follow-up to 46e6b9b

Signed-off-by: Paul Donald <newtwen+github@gmail.com>
  • Loading branch information
@systemcrash
systemcrash committed Oct 23, 2024
1 parent e662dc8 commit 1300761
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions applications/luci-app-firewall/htdocs/luci-static/resources/view/firewall/zones.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,10 @@ return view.extend({
s.anonymous = true;
s.addremove = false;

o = s.option(form.RichListValue, "offloading_type", _("Offloading type"));
o = s.option(form.RichListValue, "offloading_type", _("Flow offloading type"));
o.value('0', _("None"));
o.value('1', _("Software offloading"), _('Software based offloading for routing with/without NAT.'));
o.value('2', _("Hardware offloading"), _('Hardware based offloading for routing with/without NAT. Requires hardware support.'));
o.value('1', _("Software flow offloading"), _('Software based offloading for routing/NAT.'));
o.value('2', _("Hardware flow offloading"), _('Hardware based offloading for routing with/without NAT.') + ' ' + _(' Requires hardware NAT support.'));

This comment has been minimized.

Sign in to view

Copy link
@arinc9

arinc9 Oct 24, 2024 •
edited
Loading

Contributor

@systemcrash This is wrong. Hardware must support flow offloading, not NAT. And flow offloading applies whether or not NAT is being used. Routing and NAT are not mutually exclusive functionality. Please keep the addition of the word "flow," and revert the remaining back to what was already there.
o.optional = false;
o.load = function (section_id) {
var flow_offloading = uci.get('firewall', section_id, 'flow_offloading');
Expand Down

0 comments on commit 1300761

Please sign in to comment.