update the look of the candidate sheet #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rounded rectangles - honor light/dark modes
lukhnos
approved these changes
Nov 23, 2023
| NSColor.selectedControlColor.setFill() | ||
| } | ||
| NSBezierPath.fill(candidateRect) | ||
| activeCandidateAttr[.foregroundColor] = NSColor.white |
There was a problem hiding this comment.
No action needed, just wanted to add a note here. I was wondering why this has to be .white instead of .selectedControlTextColor, and then after I tried this I found the latter could cause the text contrast to be too low in the Light theme (as selected contorl text color is very dark). This LGTM.
lukhnos
reviewed
Nov 23, 2023
Packages/CandidateUI/Sources/CandidateUI/HorizontalCandidateController.swift
Show resolved
Hide resolved
lukhnos
added a commit
that referenced
this pull request
Nov 23, 2023
…-look Restore PR #383 "update the look of the candidate sheet" with an additional fix
zonble
pushed a commit
to zonble/McBopomofo
that referenced
this pull request
Nov 28, 2023
This makes sure that, after the recent UI overhaul (PR openvanilla#385, openvanilla#383), we now honor the "Scroll bar behavior" settings in System Preferences > Appearance. This also fixes the problem with the .legacy style: that the scroll bar is always visible and always gets in the highlighted item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intended to fix #310