add padding bottom to avoid overlap with banners #2454
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eb into CORE-802-content-overlaps
RoyEJohnson
reviewed
Mar 31, 2025
| @@ -63,7 +78,12 @@ const PageToasts = (props: ToastProps | {}) => { | |||
| const mobileToolbarOpen = useSelector(mobileToolbarOpenSelector); | |||
|
|
|||
| return ( | |||
| <ToastContainerWrapper role='alertdialog' {...props} mobileToolbarOpen={mobileToolbarOpen}> | |||
| <ToastContainerWrapper | |||
| role='alertdialog' | |||
There was a problem hiding this comment.
I think that with the role "alertdialog" it does not matter that the content overlaps.
It was previously "alert". The difference is that "alertdialog" is something that is supposed to be dismissed -- like these. That role change was a change I made recently.
There was a problem hiding this comment.
We should cancel the card CORE-802 ?
There was a problem hiding this comment.
I think it should be reviewed along with CORE-804 (the card my PR was attached to). I think they're effectively the same.
I don't think it's wrong to make room for the boxes, but I think if we want to do that, we might just want to have them appear in a reserved space rather than absolute-positioned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-802
The issue more than resize text is related with overlap text in all resolutions. Instead of only focus on small resolutions, I added padding according resolutions. The padding is set by the number of toast messages in queu and a constant value taken from an aprox height of those toastBanners
Screen.Recording.2025-03-31.at.1.50.50.PM.mov