disable single resource api. #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morvencao
force-pushed
the
br_disable_resource_api
branch
8 times, most recently
from
d7704b4 to
1d1d594
Compare
morvencao
force-pushed
the
br_disable_resource_api
branch
2 times, most recently
from
97e1dd4 to
6c26282
Compare
Signed-off-by: morvencao <lcao@redhat.com>
morvencao
force-pushed
the
br_disable_resource_api
branch
from
6c26282 to
070bf2e
Compare
|
/assign @clyang82 |
clyang82
reviewed
Feb 24, 2025
README.md
Outdated
| ocm login --token=${OCM_ACCESS_TOKEN} --url=http://localhost:8000 | ||
|
|
||
| ``` | ||
|
|
||
| #### Get a new Resource | ||
| This will be empty if no Resource is ever created | ||
| #### List the resource bundle |
There was a problem hiding this comment.
change it to List the consumer. in this step, the result is empty. then create a consumer and list again.
|
|
||
| ## Preparation | ||
|
|
||
| 1. Enable gRPC server by passing `--enable-grpc-server=true` to the maestro server start command: |
There was a problem hiding this comment.
Do we need to enable gPRC server manually? I think we should make it enabled by default. WDYT?
There was a problem hiding this comment.
yes, we can do it.
|
/ok-to-test |
Signed-off-by: morvencao <lcao@redhat.com>
morvencao
force-pushed
the
br_disable_resource_api
branch
from
30c1a9e to
2492c34
Compare
|
/ok-to-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://issues.redhat.com/browse/ACM-17947
This PR includes the following changes:
/api/maestro/v1/resourcesendpoints, which means the originalresourceAPI object no longer exists./api/maestro/v1/resource-bundlesGET/LIST methods for listing/getting resource bundles./api/maestro/v1/resource-bundles/<id>to remove a resource bundle.