[Backport 2.x] AuditMessage validation in tests should be more useful / removed #3726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
… / removed (#3596) Changed validateMsgs in AbstractAuditlogUnitTest.java to throw exceptions with descriptions instead of just returning true or false. Signed-off-by: Prabhas Kurapati <prabhask@berkeley.edu> (cherry picked from commit deff842) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #3726 +/- ##
============================================
+ Coverage 64.88% 64.90% +0.01%
- Complexity 3634 3635 +1
============================================
Files 285 285
Lines 20535 20535
Branches 3386 3386
============================================
+ Hits 13325 13329 +4
+ Misses 5532 5528 -4
Partials 1678 1678 |
cwperks
previously approved these changes
Nov 17, 2023
willyborankin
previously approved these changes
Nov 17, 2023
DarshitChanpura
dismissed stale reviews from willyborankin and cwperks
via
35b7a31
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
approved these changes
Dec 5, 2023
peternied
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport deff842 from #3596.