Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Update Imports to Match OpenSearch #168

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

sejli
Copy link
Member

@sejli sejli commented Jul 14, 2023

Description

Fixes our build issues and update imports to reflect the library changes in OpenSearch.
Tested using ./gradlew clean build and ./gradlew check.

Issues Resolved

#167

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sean Li <lnse@amazon.com>
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #168 (3a17bed) into main (721a695) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #168   +/-   ##
=========================================
  Coverage     83.44%   83.44%           
  Complexity      331      331           
=========================================
  Files            42       42           
  Lines          1250     1250           
  Branches        153      153           
=========================================
  Hits           1043     1043           
  Misses          130      130           
  Partials         77       77           
Impacted Files Coverage Δ
...search/search/relevance/SearchRelevancePlugin.java 0.00% <ø> (ø)
...rch/relevance/actionfilter/SearchActionFilter.java 85.45% <ø> (ø)
...e/configuration/SearchConfigurationExtBuilder.java 67.64% <ø> (ø)
...evance/configuration/TransformerConfiguration.java 100.00% <ø> (ø)
...ntelligentranking/client/KendraClientSettings.java 97.36% <ø> (ø)
...configuration/KendraIntelligentRankerSettings.java 83.33% <ø> (ø)
...uration/KendraIntelligentRankingConfiguration.java 82.65% <ø> (ø)
.../KendraIntelligentRankingConfigurationFactory.java 0.00% <ø> (ø)
...nking/model/KendraIntelligentRankingException.java 100.00% <ø> (ø)
...igentranking/client/PersonalizeClientSettings.java 96.55% <ø> (ø)
... and 2 more

@mingshl mingshl added the maintenance A change to add support for new versions of OpenSearch or OpenSearch Dashboards from upstream. label Jul 14, 2023
@sejli sejli merged commit f51c12c into opensearch-project:main Jul 14, 2023
@sejli sejli added the backport 2.x Backport to 2.x branch label Jul 17, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 17, 2023
Signed-off-by: Sean Li <lnse@amazon.com>
(cherry picked from commit f51c12c)
noCharger pushed a commit that referenced this pull request Jul 25, 2023
Signed-off-by: Sean Li <lnse@amazon.com>
(cherry picked from commit f51c12c)

Co-authored-by: Sean Li <lnse@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch maintenance A change to add support for new versions of OpenSearch or OpenSearch Dashboards from upstream.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants