[Manual Backport 0.5-nexus] Add read/write bytes metrics (#803) #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add read/write bytes metrics Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Add unit test Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Address comments Signed-off-by: Tomoyuki Morita <moritato@amazon.com> --------- Signed-off-by: Tomoyuki Morita <moritato@amazon.com> (cherry picked from commit 2a647d4)
ykmr1224
requested review from
dai-chen,
rupal-bq,
mengweieric,
vamsimanohar,
penghuo,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
noCharger
approved these changes
Oct 30, 2024
| @@ -120,6 +120,7 @@ lazy val flintCore = (project in file("flint-core")) | |||
| "software.amazon.awssdk" % "auth-crt" % "2.28.10", | |||
| "com.fasterxml.jackson.core" % "jackson-core" % jacksonVersion, | |||
| "com.fasterxml.jackson.core" % "jackson-databind" % jacksonVersion, | |||
| "org.projectlombok" % "lombok" % "1.18.30" % "provided", | |||
There was a problem hiding this comment.
this is added in flintCommons, do we still need it in flintCore?
There was a problem hiding this comment.
I used lombok for this PR in flintCore.
There was a problem hiding this comment.
i mean flintCore depends on flintCommons, do we still need it?
There was a problem hiding this comment.
if we want to remove it we can first remove in main. Let's keep this pr just as a simple backport
seankao-az
approved these changes
Oct 30, 2024
seankao-az
merged commit f790d35
into
opensearch-project:0.5-nexus
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually backport 2a647d4 from #803
Auto backport failed due to conflict in build.sbt