Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update incremental build to support qualifier on Jenkins #585

Merged

Conversation

peterzhuamazon
Copy link
Member

Description

Update incremental build to support qualifier on Jenkins

Issues Resolved

opensearch-project/opensearch-build#3747

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaiksaya
Copy link
Member

gaiksaya commented Feb 20, 2025

@peterzhuamazon I believe label should be backport 8.2. We should have cut 8.2 branch for patches. Looks like it was miss.
Also wondering if this is urgent. I have couple of PRs going in next release (8.3.0 or 9.0) can go in with few more changes.
Thanks!

@zelinh
Copy link
Member

zelinh commented Feb 20, 2025

@peterzhuamazon I believe label should be backport 8.2. We should have cut 8.2 branch for patches. Looks like it was miss. Also wondering if this is urgent. I have couple of PRs going in next release (8.3.0 or 9.0) can be go in with few more changes. Thanks!

I think right now we don't have patch branches since 2.x in this repo, while we still cut tags for each.

@gaiksaya
Copy link
Member

I think right now we don't have patch branches since 2.x in this repo, while we still cut tags for each.

That's a miss. We need to have those. Moving forward please take care of that as maintainers of the repo.
Thanks!

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (9ad1886) to head (e3b2bfd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #585   +/-   ##
=========================================
  Coverage     84.61%   84.61%           
  Complexity      133      133           
=========================================
  Files           123      123           
  Lines           780      780           
  Branches         86       86           
=========================================
  Hits            660      660           
  Misses           33       33           
  Partials         87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterzhuamazon peterzhuamazon merged commit 388afe3 into opensearch-project:main Feb 20, 2025
9 checks passed
@peterzhuamazon peterzhuamazon deleted the qualifier-incremental-s3 branch February 20, 2025 21:53
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 20, 2025
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit 388afe3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gaiksaya pushed a commit to gaiksaya/opensearch-build-libraries that referenced this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants