Introduce faiss patch to share ivfpq precomp table #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a patch for faiss library to share ivfpq table between faiss indices. Patch is built from: jmazanec15/faiss@c5ca072. In addition, modify different locations to apply patch. Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
naveentatikonda,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/remove-redunant-allocs #1520 +/- ##
====================================================================
- Coverage 85.14% 85.12% -0.02%
+ Complexity 1281 1280 -1
====================================================================
Files 168 168
Lines 5232 5232
Branches 495 495
====================================================================
- Hits 4455 4454 -1
Misses 570 570
- Partials 207 208 +1 ☔ View full report in Codecov by Sentry. |
|
Are the Mac failures expected? |
|
@ryanbogan Flaky test: #1522. This change wont impact it |
ryanbogan
approved these changes
Mar 7, 2024
martin-gaievski
approved these changes
Mar 7, 2024
jmazanec15
merged commit d818487
into
opensearch-project:feature/remove-redunant-allocs
59 of 62 checks passed
jmazanec15
added a commit
to jmazanec15/k-NN-1
that referenced
this pull request
Mar 18, 2024
…t#1520) Introduces a patch for faiss library to share ivfpq table between faiss indices. Patch is built from: jmazanec15/faiss@c5ca072. In addition, modify different locations to apply patch. Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15
added a commit
that referenced
this pull request
Mar 18, 2024
Introduces a patch for faiss library to share ivfpq table between faiss indices. Patch is built from: jmazanec15/faiss@c5ca072. In addition, modify different locations to apply patch. Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15
added a commit
to jmazanec15/k-NN-1
that referenced
this pull request
Mar 18, 2024
…t#1520) Introduces a patch for faiss library to share ivfpq table between faiss indices. Patch is built from: jmazanec15/faiss@c5ca072. In addition, modify different locations to apply patch. Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15
added a commit
that referenced
this pull request
Mar 18, 2024
Introduces a patch for faiss library to share ivfpq table between faiss indices. Patch is built from: jmazanec15/faiss@c5ca072. In addition, modify different locations to apply patch. Signed-off-by: John Mazanec <jmazane@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First of 3 PRs to share table amongst IVFPQ-l2 indices coming from #1507. This PR introduces the faiss patch change. In future release, we will get rid of this patch when we can achieve this functionality with faiss. Related issue here: facebookresearch/faiss#3271. Will merge into feature branch and once all 3 are merged, will merge into main.
Patch is built from: jmazanec15/faiss@c5ca072. For convenience, I opened up a PR on my faiss clone for review: jmazanec15/faiss#1. Please feel free to leave comments there.
In addition, modified different locations to apply patch.
Issues Resolved
#1507 - partial
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.