Jira reuse atlassian commons module #5441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
…opies Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
…atlassian-commons
san81
requested review from
sb2k16,
chenqi0805,
engechas,
srikanthjg,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
Galactus22625
approved these changes
Feb 19, 2025
sb2k16
reviewed
Feb 19, 2025
| @@ -0,0 +1,10 @@ | |||
| package org.opensearch.dataprepper.plugins.source.atlassian.utils; | |||
There was a problem hiding this comment.
Thanks for catching this. Added copyright.
| @@ -34,12 +34,12 @@ | |||
| import static org.opensearch.dataprepper.plugins.source.atlassian.utils.Constants.SLASH; | |||
|
|
|||
| /** | |||
| * The type Jira service. | |||
| * The type Atlassian OAuth2 service. | |||
There was a problem hiding this comment.
nit: should it be Atlassian OAuth2 Service Config
There was a problem hiding this comment.
Adjusted the comment
| @@ -33,4 +33,8 @@ public class ConfluenceSourceConfig extends AtlassianSourceConfig implements Cra | |||
| @JsonProperty("acknowledgments") | |||
| private boolean acknowledgments = false; | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
Is there a set of tests for this file?
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
dlvenable
approved these changes
Feb 19, 2025
sb2k16
approved these changes
Feb 19, 2025
divbok
pushed a commit
to divbok/data-prepper
that referenced
this pull request
Feb 24, 2025
* jira making use of atlassian commons * Making OAuth2 flow work for both Confluence and Jira Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I added Confluence as a source, I moved the Atlassian authentication code to
atlassian-commonsmodule as the authentication methods for both jira and confluence are the same. Confluece is already making use of this common module and now with this PR, I am making jira to also relay on the common module. Deleted any redundant jira specific authentication code as it is fully reusing the code fromatlassian-commonsmodule.Also, fixed the flow related OAuth2 while also reusing the code between Jira and Confluence
Majority of the code changes are deletes and import fixes. Out of 39 files changed in this PR, 20 of them are just file deletions.
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.