Update workspace nodes/edges; misc fixes #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohltyler
added
bug
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
force-pushed
the
misc-fixes
branch
from
311931b to
1345e65
Compare
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
saimedhi
approved these changes
Sep 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
* cover few edge cases Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Make quick config fields all fullwidth Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * word consistency; add more known embeddings Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * remove unnecessary spacing Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Rename UI component from query -> search request Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * rename results -> search response Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * update names; remove unnecessary components; add detailed i/o Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * rename Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Fix & improve test Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit c8bdacc)
ohltyler
added a commit
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor PR with bunch of random small fixes/improvements
Screenshot showing updated workspace components nodes & edges:
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.