-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flaky Test] Fix Flaky Test ShuffleForcedMergePolicyTests.testDiagnostics #17392
Conversation
server/src/test/java/org/opensearch/lucene/index/ShuffleForcedMergePolicyTests.java
Show resolved
Hide resolved
❌ Gradle check result for 3649f79: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 3649f79: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 3649f79: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 3649f79: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 30137d5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
MetadataCreateIndexServiceTests.testCreateIndexWithContextDisabled #17291 |
@kkewwei I don't think your branch is synced completely with the latest commits on main. I see that https://github.com/kkewwei/OpenSearch/tree/fix_17294 is 4 commits behind. Can you sync and push? |
@cwperks My mistake, thank you very much. |
Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17392 +/- ##
============================================
+ Coverage 72.37% 72.46% +0.08%
- Complexity 65519 65530 +11
============================================
Files 5291 5291
Lines 304302 304325 +23
Branches 44174 44181 +7
============================================
+ Hits 220240 220526 +286
+ Misses 65997 65693 -304
- Partials 18065 18106 +41 ☔ View full report in Codecov by Sentry. |
Description
There is a situation where all segments are triggered to merged into one segment before forceMerging. When forceMerge is called, there will be no segments to merge.
reader.leaves()
contains the segments being merged.It may be caused by upgrading to lucene10.
Related Issues
Resolves #17294
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.