-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tiered Caching] Remove PLUGGABLE_CACHE feature flag #17344
base: main
Are you sure you want to change the base?
[Tiered Caching] Remove PLUGGABLE_CACHE feature flag #17344
Conversation
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
f8ebfd4
to
cb6dea2
Compare
Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com>
❌ Gradle check result for c5cf640: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
❌ Gradle check result for 6126527: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test: #17291 |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
❌ Gradle check result for d212d39: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for d95e24c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
d95e24c
to
2a6794f
Compare
❌ Gradle check result for 2a6794f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky tests: #17369 |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
❌ Gradle check result for 9c48b31: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
❌ Gradle check result for 410f062: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
❌ Gradle check result for 470251e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test: #17291 |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
❕ Gradle check result for 8a559cb: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17344 +/- ##
============================================
+ Coverage 72.34% 72.47% +0.13%
- Complexity 65480 65598 +118
============================================
Files 5291 5291
Lines 304313 304313
Branches 44176 44174 -2
============================================
+ Hits 220142 220566 +424
+ Misses 66133 65690 -443
- Partials 18038 18057 +19 ☔ View full report in Codecov by Sentry. |
Description
As tiered caching will no longer be experimental in 3.0, removes its feature flag. Now users can always specify a store name via setting, and cache implementations will always track their own stats as exposed in
GET _nodes/stats/caches/...
.Modifies some UTs to account for this. Manually tested with debugger that the TSC can be used in the IRC via setting with the new changes. Also manually checked the response in
GET _nodes/stats/caches/request_cache
is populated even for the default cache.Related Issues
Resolves #17343
Sub-issue of #17303
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.