Skip to content

Commit

Permalink
Remove daemonize option from prterun
Browse files Browse the repository at this point in the history
Makes no sense to allow prterun to daemonize given that
it is intended to execute a single job and then terminate.
You can still run it in the background, if desired.

Signed-off-by: Ralph Castain <rhc@pmix.org>
  • Loading branch information
rhc54 committed Dec 5, 2023
1 parent 6b45a6f commit cd715fa
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 11 deletions.
7 changes: 0 additions & 7 deletions src/docs/show-help-files/help-prterun.rst
Original file line number Diff line number Diff line change
Expand Up @@ -268,9 +268,6 @@ option to the help request as ``--help <option>``.
* - ``--allow-run-as-root``
- Allow execution as root (**STRONGLY DISCOURAGED**)

* - ``--daemonize``
- Daemonize the prterun and its daemons into the background

* - ``--forward-signals <signals>``
- Comma-delimited list of additional signals (names or integers) to forward
to application processes [``none`` => forward nothing].
Expand Down Expand Up @@ -356,10 +353,6 @@ the directive appears.

.. include:: /prrte-rst-content/cli-stream-buffering.rst

[daemonize]

Daemonize the prterun and the DVM daemons into the background

[system-server]

Start prterun and its daemons as the system server on their nodes
Expand Down
1 change: 0 additions & 1 deletion src/mca/schizo/prte/schizo_prte.c
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ static struct option prterunoptions[] = {
PMIX_OPTION_DEFINE(PRTE_CLI_TUNE, PMIX_ARG_REQD),

// DVM options
PMIX_OPTION_DEFINE(PRTE_CLI_DAEMONIZE, PMIX_ARG_NONE),
PMIX_OPTION_DEFINE(PRTE_CLI_SET_SID, PMIX_ARG_NONE),
PMIX_OPTION_DEFINE(PRTE_CLI_REPORT_PID, PMIX_ARG_REQD),
PMIX_OPTION_DEFINE(PRTE_CLI_REPORT_URI, PMIX_ARG_REQD),
Expand Down
3 changes: 0 additions & 3 deletions src/tools/prte/prte.c
Original file line number Diff line number Diff line change
Expand Up @@ -559,9 +559,6 @@ int main(int argc, char *argv[])
prte_pmix_server_globals.singleton = strdup(opt->values[0]);
}

/* Setup MCA params */
prte_register_params();

/* default to a persistent DVM */
prte_persistent = true;

Expand Down

0 comments on commit cd715fa

Please sign in to comment.