[PRE REVIEW]: pymccrgb: Color- and curvature-based classification of multispectral point clouds in Python

[whedon]

Submitting author: @rmsare (Robert Sare)
Repository: http://github.com/rmsare/pymccrgb
Version: v0.1.0
Editor: @kthyng
Reviewers: @martibosch, @daniellivingston

Author instructions

Thanks for submitting your paper to JOSS @rmsare. Currently, there isn't an JOSS editor assigned to your paper.

@rmsare if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

[whedon]

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

PDF failed to compile for issue #1760 with the following error:

Can't find any papers to compile :-(

[danielskatz]

@rmsare - it looks like the repo you entered doesn't exist - but it's just that the http:// was missing - I've added it now
@arfon - does this need to be changed in an internal database as well?

[danielskatz]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

PDF failed to compile for issue #1760 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/1760 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/lib/whedon/processor.rb:61:in find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

[danielskatz]

@rmsare - can you accept stgl/pymccrgb#14 and then enter a new comment in this issue @whedon generate pdf to see if that fixes the problem

[rmsare]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

👉 Check article proof 📄 👈

[rmsare]

Ack, thank you @danielskatz for fixing these issues.

I'd like to note that one of the references -- Pedregosa et al, 2011 -- does not have a DOI. The original JMLR article and arxiv version do not have DOIs and the article isn't available in CrossRef as far as I can tell.

[rmsare]

@whedon check references

[whedon]

Attempting to check references...

[danielskatz]

that's fine - you may want to mention this on the review thread once we get an editor and reviewers and we start the review

[danielskatz]

👋 @kthyng - would you be willing to edit this submission?

[kthyng]

@danielskatz for sure!

[kthyng]

@whedon assign @kthyng as editor

[whedon]

OK, the editor is @kthyng

[kthyng]

Hi @rmsare! Can you suggest around 5 possible reviewers from this list of volunteers: https://bit.ly/joss-reviewers?

[rmsare]

Thanks, I think Katy Barnhart (kbarnhart), Margaux Mochene (margauxmouchene), Marti Bosch (martibosch), Joseph Stachelek (jsta), Declan Valters (dvalters) could be potential reviewers.

[kthyng]

Thanks!

Hi @margauxmouchene and @martibosch! Are you interested and able to review this JOSS submission in about the next three weeks? You can find more details here.

[martibosch]

Hello @kthyng , I'd be happy to review this submission ✌️ If you confirm me as reviewer, I will find some time to go through it during the next three weeks.
Martí

[rmsare]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

👉 Check article proof 📄 👈

[kthyng]

@martibosch great! I'll add you as a reviewer, but we'll need to wait to start the actual review until we have a second reviewer.

[kthyng]

@whedon assign @martibosch as reviewer

[whedon]

OK, the reviewer is @martibosch

[kthyng]

Hi @callumrollo, @daniellivingston, and @banesullivan! I need one more reviewer for this JOSS submission. Are any of you interested in reviewing? We ask for reviews within about 3 weeks and you can get more information about the process and details here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

[daniellivingston]

Hi @kthyng , I would be more than happy to review this submission.

[kthyng]

@daniellivingston perfect! We can proceed with this review then.

[kthyng]

@whedon add @daniellivingston as reviewer

[whedon]

OK, @daniellivingston is now a reviewer

[kthyng]

@whedon start review

[whedon]

OK, I've started the review over in #1777. Feel free to close this issue now!

[banesullivan]

Hi @kthyng - looks like @daniellivingston beat me here! This library looks really cool and I'd be happy to review if needed (although a bit busy lately). Thanks for thinking of me! I'll definitely be scoping out this package and maybe finding a way to couple PyVista with it

[kthyng]

@martibosch and @daniellivingston head on over to #1777 to do your reviews.

@banesullivan Thanks for being willing to help out! I'll keep you in mind for the next relevant submission.

[sdruskat]

<AT>rmsare - it looks like the repo you entered doesn't exist - but it's just that the http:// was missing - I've added it now
@arfon - does this need to be changed in an internal database as well?

Hi @arfon and @danielskatz, sorry to revive this after 4 years. I stumbled over the live JSON representation of the metadata missing the protocol prefix for the software_repository field. I can catch this in my retrieval code, but should this be fixed in the DB?

Thanks!