Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad software URL in old paper #1293

Closed
danielskatz opened this issue Nov 8, 2023 · 4 comments
Closed

Bad software URL in old paper #1293

danielskatz opened this issue Nov 8, 2023 · 4 comments

Comments

@danielskatz
Copy link
Collaborator

As noticed by @sdruskat in openjournals/joss-reviews#1760 (comment), the software repo for the software in https://doi.org/10.21105/joss.01777 is entered as github.com/rmsare/pymccrgb rather than the correct https://github.com/rmsare/pymccrgb which causes the link to be treated as local and not to work.

Can this be fixed in our metadata, and then can the metadata be re-issued?

@xuanxu
Copy link
Member

xuanxu commented Nov 10, 2023

Fixed!

@xuanxu xuanxu closed this as completed Nov 10, 2023
@sdruskat
Copy link

@xuanxu & @danielskatz Sorry for the postscript, but I found two more of the same errors in the current complete set of published papers:

@danielskatz
Copy link
Collaborator Author

Thanks for finding these.
I hope @xuanxu can fix them fairly easily.

@xuanxu - do you think this is something we should be checking for in the generate pdf processing?

@xuanxu
Copy link
Member

xuanxu commented Dec 1, 2023

Fixed! From now on the JOSS site doesn't allow relative URLs for new submissions.

@xuanxu xuanxu closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants