Update label and change default dev locale #13134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it clearer where things are going from, and to. I will re-use this order on the next screen.
Making way for a review step.
If there's a matching product in OFN already, a link will appear.
en_AU contains translations for most keys, and is subject to change. So if you change the value of an existing key in en.yml, you won't see the change in your dev environment. Maybe it's confusing because it's not called 'development', but I think the comment above explains well enough.
This could have been done in Transifex, but I figured it would be quicker to just go ahead and update here.
Because it doesn't fit in db field spree_users.local with limit: 6. We could extend the field but it seemed silly because it's only used in test/dev environments.
dacook
added
the
technical changes only
mkllnk
approved these changes
Feb 12, 2025
.env.development
Outdated
Comment on lines
9
to
11
| # successful fallback to `en`. You will also see up-to-date text used | ||
| # in production | ||
| LOCALE="en_AU" | ||
| LOCALE="en_TEST" |
There was a problem hiding this comment.
Part of the comment is not valid anymore:
You will also see up-to-date text used in production
There was a problem hiding this comment.
True. The downside to this change is that we're not looking at a production locale.
The upside is that it's agnostic of production locales.
🤷
| enterprise: "Enterprise" | ||
| enterprise: "Create products for enterprise" |
There was a problem hiding this comment.
Transifex may just override this again.
[skip ci]
|
I've already tested as per the above notes. Not sure it's worth getting someone else to test. But in any case this is blocked until dependent PR is merged. |
|
I don't think that we need to test this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Funded Feature. Please track ALL ASSOCIATED WORK under the associated tracking code
#11678 DFC OrdersWhat? Why?
I attempted to change a default translation, but wasn't able to see it at first, because the dev environment defaults to en_AU (and I didn't change the en_AU.yml file).
This was confusing, and I thought it would be less confusing to use the same setup that we use for specs.
Now, we probably shouldn't be updating the default translation. We could just update it as needed for each locale.
But in this case, it's a new feature that hasn't been rolled out yet, so I thought it worth updating the default to something more descriptive.
A field label is updated, but it hardly seems worth announcing as a user-facing change. It will be communicated to Garethe (who requested it) anyway.
What should a dev test?
.env.development.localthat overrides thisDependencies
(PR starts at
Use test locale instead of real one in developmente7054f7)