Direct people to refresh OIDC connection when needed #13126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not the best UX but the easiest next step to implement. Next we should: * Include link in error message instead of redirecting straight there. Otherwise users may feel disoriented. * Provide a custom error message?
The colour of the link is really bad though.
mkllnk
added
the
user facing changes
The default aqua link colour looked aweful on orange/red background. I tried a few different standard colours but couldn't get it right. So I reverted to the web standard link style: underline. That's looks pretty good. I personally think that we should use the more for links.
dacook
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Funded Feature. Please track ALL ASSOCIATED WORK under the associated tracking code #11678 DFC Orders
What? Why?
@dacook made a really good start on this issue. I tailored the error message to this specific case and wrote a spec covering this.
What should we test?
OidcAccount.where(user_id: 0).update_all(refresh_token: "aaa", updated_at: 1.year.ago)https://env-0105831.jcloud-ver-jpe.ik-server.com/api/dfc/Enterprises/test-hodmedod/SuppliedProductsRelease notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates
Review comment: The last commit adds a new style for links. Before it was looking like this:
