-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problem input #1646
base: master
Are you sure you want to change the base?
Fix problem input #1646
Conversation
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1646 +/- ##
==========================================
- Coverage 93.24% 93.21% -0.04%
==========================================
Files 1100 1100
Lines 21803 21809 +6
Branches 4711 4713 +2
==========================================
- Hits 20330 20329 -1
- Misses 1401 1406 +5
- Partials 72 74 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The quick toolbar change looks good to me! I did not check on the other changes.
Description
Fixes #1637 so that clicking editor toolbars doesn't try to close the modal.
Partially fixes #1636
Before:
![Screenshot](https://private-user-images.githubusercontent.com/945577/409677956-b7981fdd-b794-420a-a106-d854f73516ea.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NTI1MTksIm5iZiI6MTczODk1MjIxOSwicGF0aCI6Ii85NDU1NzcvNDA5Njc3OTU2LWI3OTgxZmRkLWI3OTQtNDIwYS1hMTA2LWQ4NTRmNzM1MTZlYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QxODE2NTlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yYjUwOWFkYzUxMTkwNDYxMzgzMDk2YWI5NmYwYzc2N2VkMjIxMWMzZjliOTUyZjRkMDI5MjBlNzcxYWEyNDYxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.f365YfsMV8lNOJbunsDSOVlhZnDXgYr407jVOq4Vn9s)
After:
![Screenshot](https://private-user-images.githubusercontent.com/945577/409677740-ab8df1a9-508b-4f33-8847-95f5bc41e2f8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NTI1MTksIm5iZiI6MTczODk1MjIxOSwicGF0aCI6Ii85NDU1NzcvNDA5Njc3NzQwLWFiOGRmMWE5LTUwOGItNGYzMy04ODQ3LTk1ZjViYzQxZTJmOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QxODE2NTlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04NzdhOTZlZDgxYzdkNGVhNDQyYjU1YjRjZDViMTBjODI1NWY2NDVmNzEwNDMwYjNjZDg2OWNhNGUxMzRmOGMyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.0k4H0SCr-MWka-pjrVdHFoFBnloXC3h1uycTnXGv9eI)
Supporting information
This "Insert" toolbar is shown in the "Expandable" text fields like Answer, Feedback, and Hint (all in the Problem editor), when you click on an empty line (or when the whole input is empty). Most people seemed fine with removing/shortening it, but I was asked on Slack to keep the "image" and "table" insertion tools. Which are also the ones in the official plugin docs for this floating toolbar plugin.
Testing instructions
Open a Problem component, both in a library and in a course. Set answers, feedback, and hints. Check that the formatting toolbars (bold/italic/etc. when you have text selected) and other editor modals (insert emoji, insert image, etc.) are clickable and working.
I also fixed a bug in the Studio header. Verify that clicking on the library name will take you back to the library home page:
![Screenshot 2025-02-04 at 10 00 08 AM](https://private-user-images.githubusercontent.com/945577/409679680-42220e84-d43e-4f01-88fe-8133f64cf8a9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NTI1MTksIm5iZiI6MTczODk1MjIxOSwicGF0aCI6Ii85NDU1NzcvNDA5Njc5NjgwLTQyMjIwZTg0LWQ0M2UtNGYwMS04OGZlLTgxMzNmNjRjZjhhOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QxODE2NTlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04NmM1ZTBmOGE3ZjVkN2JlNjM5YTc3YThiNzg0ZTQ3NjFhOWU0MWMwZTQwZDhhOGExNTNkMzhjYjUwM2UyMjZmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.4RiSauDymfRW-ci76cPXlJkeeY8PCFB3N-bvXaixgBI)