Clear all ProctoredExamSoftwareSecureReviewHistory instances of PII #1266
+7
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request changes the time at which we read instances of the
ProctoredExamSoftwareSecureReviewHistory
model. This is necessary because the act of saving theProctoredExamSoftwareSecureReview
model causes the pre-save instance to be saved to theProctoredExamSoftwareSecureReviewHistory
table. Because we read instances of theProctoredExamSoftwareSecureReviewHistory
model prior to calling save on the instances of theProctoredExamSoftwareSecureReview
model, we do not have the full queryset we need. Reading the instances of theProctoredExamSoftwareSecureReviewHistory
model from the database after we clear all the instances of theProctoredExamSoftwareSecureReview
model fixes this issue.JIRA:
COSMO-595 (private)
Pre-Merge Checklist:
edx_proctoring/__init__.py
andpackage.json
if these changes are to be released.CHANGELOG.rst
Post-Merge: