Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear all ProctoredExamSoftwareSecureReviewHistory instances of PII #1266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichaelRoytman
Copy link
Contributor

@MichaelRoytman MichaelRoytman commented Feb 7, 2025

Description:

This pull request changes the time at which we read instances of the ProctoredExamSoftwareSecureReviewHistory model. This is necessary because the act of saving the ProctoredExamSoftwareSecureReview model causes the pre-save instance to be saved to the ProctoredExamSoftwareSecureReviewHistory table. Because we read instances of the ProctoredExamSoftwareSecureReviewHistory model prior to calling save on the instances of the ProctoredExamSoftwareSecureReview model, we do not have the full queryset we need. Reading the instances of the ProctoredExamSoftwareSecureReviewHistory model from the database after we clear all the instances of the ProctoredExamSoftwareSecureReview model fixes this issue.

JIRA:

COSMO-595 (private)

Pre-Merge Checklist:

  • Updated the version number in edx_proctoring/__init__.py and package.json if these changes are to be released.
  • Described your changes in CHANGELOG.rst
  • Confirmed Github reports all automated tests/checks are passing.
  • Approved by at least one additional reviewer.

Post-Merge:

  • Create a tag matching the new version number.

This commit changes the time at which we read instances of the ProctoredExamSoftwareSecureReviewHistory model. This is necessary because the act of saving the ProctoredExamSoftwareSecureReview model causes the pre-save instance to be saved to the ProctoredExamSoftwareSecureReviewHistory table. Because we read instances of the ProctoredExamSoftwareSecureReviewHistory model prior to calling save on the instances of the ProctoredExamSoftwareSecureReview model, we do not have the full queryset we need. Reading the instances of the ProctoredExamSoftwareSecureReviewHistory model from the database after we clear all the instances of the ProctoredExamSoftwareSecureReview model fixes this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant