Add course runs endpoint. #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that tests are passing, but the CI build is failing because of quality violations. Since we've changed the interface of |
| @@ -8,5 +8,6 @@ | |||
| router = routers.SimpleRouter() | |||
| router.register(r'catalogs', views.CatalogViewSet) | |||
| router.register(r'courses', views.CourseViewSet, base_name='course') | |||
| router.register(r'course-runs', views.CourseRunViewSet, base_name='course-run') | |||
There was a problem hiding this comment.
Silly, I know, but we need to use course_runs to support Slumber. See samgiles/slumber#44.
peter-fogg
force-pushed
the
peter-fogg/course-runs
branch
from
7ed5e4a to
02766da
Compare
ECOM-3898
I'm leaving many of these errors to be resolved when we've got a solution for course search.
peter-fogg
force-pushed
the
peter-fogg/course-runs
branch
from
02766da to
9f49c6f
Compare
bderusha
force-pushed
the
bderusha/add-model-scaffolding
branch
2 times, most recently
from
8109b21 to
2e8f6f2
Compare
clintonb
force-pushed
the
bderusha/add-model-scaffolding
branch
10 times, most recently
from
e094548 to
8b30f7d
Compare
bderusha
force-pushed
the
bderusha/add-model-scaffolding
branch
4 times, most recently
from
e5902c5 to
4b72411
Compare
bderusha
force-pushed
the
bderusha/add-model-scaffolding
branch
5 times, most recently
from
60cbf72 to
f9d67ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECOM-3898
@bderusha @clintonb I've based this PR off Bill's branch. The code will need some updating once the data model is finalized, but this is a start for now.