Skip to content
This repository has been archived by the owner on Mar 15, 2019. It is now read-only.

Remove beyonic payment service from the project and reimplement the payment gateway #4

Open
wants to merge 10 commits into
base: development
Choose a base branch
from
Open

Remove beyonic payment service from the project and reimplement the payment gateway #4

wants to merge 10 commits into from

Conversation

vladimirfomene
Copy link
Collaborator

@vladimirfomene vladimirfomene commented Jul 14, 2017 •
edited
Loading

Remove the beyonic handler from the project.
Implement loan disbursement use case
Implement customer initiated transactions use case
Implement all network request asynchronously.
Fixed bugs on payment gateway http interface.
Remove class files.

@vladimirfomene vladimirfomene requested a review from OmexIT July 14, 2017 10:56
@vladimirfomene vladimirfomene changed the title Create .gitignore for repo, add .idea to it and removes it from the local repository. Create .gitignore for repo, add .idea to it and removes it from the local repository. Add loan disbursement functionality Jul 21, 2017
@vladimirfomene vladimirfomene changed the title Create .gitignore for repo, add .idea to it and removes it from the local repository. Add loan disbursement functionality Remove beyonic payment service from the project and reimplement the payment gateway Aug 8, 2017
OmexIT
OmexIT suggested changes Aug 16, 2017
View reviewed changes
Copy link
Collaborator

@OmexIT OmexIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include the json generated Classes as a separate library project? Can you do this?

OmexIT
OmexIT suggested changes Sep 20, 2017
View reviewed changes
Copy link
Collaborator

@OmexIT OmexIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add .ignore file to remove all these .idea files and .class files. Only include source code

@OmexIT
Copy link
Collaborator

OmexIT commented Sep 20, 2017 •
edited by vladimirfomene
Loading

This code is very hard to review. Can you first update the .ignore as requested, so that I can proceed with the review.

@vladimirfomene
Copy link
Collaborator Author

@OmexIT Thanks for the feedback, I will work on that this weekend and I will also refactor the code to ease review.

@awasum
Copy link
Collaborator

awasum commented Oct 4, 2017

Hello @vladimirfomene , Have you made the changes requested by @OmexIT ??

@awasum
Copy link
Collaborator

awasum commented Oct 4, 2017

We have a few things we discussed about in the last meeting concerning the use of POST instead of GET for retrieving data....Have u had time to look at those?
Also we need to start looking at transaction reconciliation (between Fineract and mobile money systems) while waiting for full requirements.

@avikganguly01
Copy link
Collaborator

avikganguly01 commented Nov 22, 2017 •
edited by vladimirfomene
Loading

Hey @vladimirfomene : Can you just squash the changes?

@vladimirfomene
Implement loan disbursement and implement beyonic's payment service
26db4c8 
Fix bugs in loan disbursement and implement withdrawal

Implement mifos service

Add domain for loan account and fixed deposit account
@vladimirfomene
Implement Customer initiated transactions service for mifos
276a7e7
@vladimirfomene
Re-Implement all mifos service methods to be asynchronous
9c72956 
Fixing bugs on incoming payment request and outgoing payments

Bug fixes in the OutboundController and the data.sql file

Remove out folder from project

Modify a .gitignore file
@vladimirfomene
Copy link
Collaborator Author

Hello @avikganguly01 ,
I have squashed the changes. Please can you have a look at them and possibly merge them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@OmexIT OmexIT OmexIT requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vladimirfomene @OmexIT @awasum @avikganguly01