-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feature:auth): migrated to cmp #2772
feat(feature:auth): migrated to cmp #2772
Conversation
@niyajali , I have used getString for stringResources if this approach is right, we can merge this PR |
@Nagarjuna0033 Upload video for other platforms like desktop, wasmJS if it's working fine |
Uploaded for desktop and for web the issue still persists we will fix in other PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nagarjuna0033 Quickly fix the following changes and let me know, we will proceed with merging this PR
feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/login/LoginScreen.kt
Outdated
Show resolved
Hide resolved
...mmonMain/kotlin/org/mifos/mobile/feature/auth/registration/RegistrationVerificationScreen.kt
Outdated
Show resolved
Hide resolved
.../auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/registration/RegistrationScreen.kt
Show resolved
Hide resolved
@niyajali I have done changes and for web we can't use stringResources because it is not supported yet |
I saw your message about stringResource not being supported in Web. Could you clarify what you mean by that? From what I understand, you can have stringResource(Res.string....) inside the common module, which should be accessible by all platforms, including Web. If you're referring to formatted strings, I've attached a piece of code that successfully uses stringResource in the common module to handle formatted strings like:
![]() |
@HekmatullahAmin we can use stringResource in commonMain but I am talking about using in cmp-web module which we want to use stringResource in |
@Nagarjuna0033 No, It should be supported on web too, create a composeResource/string/string.xml like before and run |
Fixes - Jira-#120
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
MM_compressed.mp4
desk_compressed.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew check
orci-prepush.sh
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.