Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

German translations of principles and glossary #58

Merged
merged 1 commit into from
Feb 22, 2022
Merged

German translations of principles and glossary #58

merged 1 commit into from
Feb 22, 2022

Conversation

heubeck
Copy link
Contributor

@heubeck heubeck commented Feb 8, 2022 •
edited
Loading

@heubeck
Copy link
Contributor Author

heubeck commented Feb 8, 2022 •
edited
Loading

@scottrigby
@schlomo
@LutzLange
@wpernath

@schlomo
Copy link
Contributor

schlomo commented Feb 9, 2022

Beautiful and spot on translation, I am very much impressed (having tried myself).

Maybe we shouldn't use country icons to represent languages? There are also German speakers who don't live in Germany...

@heubeck
Copy link
Contributor Author

heubeck commented Feb 9, 2022

Beautiful and spot on translation, I am very much impressed (having tried myself).

Maybe we shouldn't use country icons to represent languages? There are also German speakers who don't live in Germany...

Thank you, and good catch: I've removed to flag.

@christianh814
Copy link
Member

Total der Hammer!

Going to go through this later today, but my German is only at a B1/B2 level so I'll need some help from @schlomo

@christianh814 christianh814 self-requested a review February 9, 2022 16:00
christianh814
christianh814 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@christianh814 christianh814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. We should have another person look through it though before merging

@ghost ghost mentioned this pull request Feb 13, 2022
Merged
sluetze
sluetze approved these changes Feb 16, 2022
View reviewed changes
Copy link

@sluetze sluetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you would have to define "IST-Zustand" if you already define "SOLL-Zustand", but it should be common knowledge.

@stuebingerb
Copy link
Contributor

Not sure if you would have to define "IST-Zustand" if you already define "SOLL-Zustand", but it should be common knowledge.

We were unsure how far we should deviate from the original source. There were a few details we struggled with in English and the English glossary e.g. also only explains the "desired state".

In the end we decided to start with a translation as close as possible to the source but we'd surely be open for a more general discussion as well.

@sluetze
Copy link

sluetze commented Feb 16, 2022

We were unsure how far we should deviate from the original source. There were a few details we struggled with in English and the English glossary e.g. also only explains the "desired state".

yes. I just remembered, that this is a translation. Nevermind. my fault.

@christianh814
Copy link
Member

Okay to merge? @scottrigby

@scottrigby
Copy link
Member

Nice work everyone! 🇩🇪😀

@christianh814 we could create a 1.1.0 release that includes this translation. Corrections to translations could be in patch versions.

@heubeck only suggestion is adding Co-authored-by commit trailer lines for each person you already credited in the commit message! Do you have their names and GitHub emails/anonymous emails? We have done this with PRs representing precious group efforts: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

@heubeck @mrempel23
@stuebingerb @steinbrueckri @beiertu-mms @buerkle-mms @kharf
German translations of principles and glossary
bb32965 
Co-authored-by: Michael Rempel <mrempel23@gmail.com>
Co-authored-by: Bernd Stübinger <bernd.stuebinger@gmx.de>
Co-authored-by: Richard Steinbrück <richard.steinbrueck@googlemail.com>
Co-authored-by: Tung Beier <beiertu@mediamarktsaturn.com>
Co-authored-by: Jochen Bürkle <buerkle@mediamarktsaturn.com>
Co-authored-by: Jan Knieling <knieling_jan@hotmail.com>
Co-authored-by: Kevin Fritz <fritzk@mediamarktsaturn.com>
Signed-off-by: Florian Heubeck <heubeck@mediamarktsaturn.com>
@heubeck
Copy link
Contributor Author

heubeck commented Feb 20, 2022

Thank you @scottrigby, we did the co-authored now properly.

@schlomo
Copy link
Contributor

schlomo commented Feb 21, 2022 •
edited
Loading

FYI, there are also technical reasons for not using flag emojis to denote language, as apparently Windows doesn't support that, see https://youtu.be/_mZBa3sqTrI?t=2915 by @dylanbeattie

I cannot validate this since I lack a suitable test environment, but I thought that it might help here to know about this.

@scottrigby scottrigby added this to the v1.1.0 milestone Feb 22, 2022
@scottrigby scottrigby merged commit 1a298e9 into open-gitops:main Feb 22, 2022
@scottrigby
Copy link
Member

Thank you, everyone! Really impressed by the collective effort here 👏 🎉💪

@mschwrdtnr mschwrdtnr mentioned this pull request Mar 3, 2022
Closed
@scottrigby scottrigby added the enhancement New feature or request label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sluetze sluetze sluetze approved these changes

@christianh814 christianh814 christianh814 approved these changes

@Vad1mo Vad1mo Vad1mo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
7 participants
@heubeck @schlomo @christianh814 @stuebingerb @sluetze @scottrigby @Vad1mo