Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limitation of Kubernetes distributions #329

Conversation

aii-nozomu-oki
Copy link
Contributor

@aii-nozomu-oki aii-nozomu-oki commented Feb 16, 2023

close #328

I decided to write this in the "Prerequisite" section of the "Start the control plane" page.
I note below the approach I didn't adopt.

  • Create a new page called "Supported Kubernetes Distributions".
    Given the number of Kubernetes distributions, this seemed premature.

  • "Kind is used for E2E testing and is 'supported' in that regard."
    This is probably an unnecessary statement since few people create products with Kind(It's mainly for testing).
    But if OCM is well tested in OpenShift (is it?) I think we can state "OCM is tested in OpenShift and Kind".

  • "EKS support is ongoing."
    There is some work toward this, but it seems to have stalled a bit.
    Initial pass at stories for token registration enhancements#69

@openshift-ci openshift-ci bot requested review from mikeshng and mprahl February 16, 2023 04:51
Signed-off-by: aii-nozomu-oki <h-nozomu.oki@inside.ai>
@aii-nozomu-oki aii-nozomu-oki force-pushed the limitations-of-Kubernetes-distributions branch from cdf826b to 0d09453 Compare February 16, 2023 04:53
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Thank you so much for your contribution! This PR makes a lot of sense.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aii-nozomu-oki, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5f15c14 into open-cluster-management-io:main Feb 16, 2023
@mikeshng
Copy link
Member

@aii-nozomu-oki thank you again for your contribution.

Could you please see the comment in open-cluster-management-io/ocm#126 (comment)

I think using the standalone control plane (or what we call the multicluster control plane) the EKS issue can be addressed.

I think the idea is EKS host ocm multicluster control plane as hub cluster which has client auth enabled, so now managed clusters can registered to ocm-mcp enabling EKS hub support.

If you agree, I think we can create a new PR to explain the limitation and the workaround. Thanks! 🙏

@aii-nozomu-oki
Copy link
Contributor Author

Oh, I didn't notice the issue.
I also interest in running OCM hub in EKS, so glad to hear the news. I'll take a look at it.
Of course, the statemenet I added can be edited in any way 🙂

@mikeshng
Copy link
Member

@aii-nozomu-oki if you have some time, could you please give it a try on EKS and see if it works? If it works, I will create a edit PR. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Describe supported/unsupported K8s distributions
3 participants