Improve dashboard upload script #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Single label is enough, and Grafana does not need to be restarted, one just needs to wait enough for it to check+process new configMaps, *and* reload of Grafana page. Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
poussa
approved these changes
Dec 5, 2024
lianhao
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Single
configMaplabel is enough, and Grafana does not need to be restarted, one just needs to wait enough for it to check+process newconfigMaps & do Grafana page reload.=> Updated script + README accordingly.
Issues
Grafana restart had following usability issues:
kubectl port-forwarding for everybody using it at the same timeType of change
Dependencies
n/a.Tests
Tested script manually with new and updated dashboard JSONs.