chat: correctly handle player and non-player chats #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chat messages from players are sent immediately to the client, but non-player chats are not. And then when the game ends, all (player and non-player) chats are sent once again. So to avoid duplicating chats from the players, keep track of the timestamp of the last chat received, to ignore the duplicates sent at the end of the game. And to also include chats during the game from non-players, don't filter on the cutoff time for non-player chats - they will always be sent just once anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chat messages from players are sent immediately to the client, but non-player chats are not. And then when the game ends, all (player and non-player) chats are sent once again.
So to avoid duplicating chats from the players, keep track of the timestamp of the last chat received, to ignore the duplicates sent at the end of the game.
And to also include chats during the game from non-players, don't filter on the cutoff time for non-player chats - they will always be sent just once anyway.