Use joinsession if session id is used

[dominikl]

Bugfix for ome/omero-insight#293 .

[jburel]

insight connected using session key

[dominikl]

👍 I have to add this case to the integration test too.

[jburel]

It works the first time but not the second time
SecurityViolation: 1 methods active.

Edit: actually it worked twice in a row then failed!

[dominikl]

Integration test: ome/openmicroscopy#6319

[dominikl]

Thanks @jburel . I think that should be all cases covered now. Should now somehow be tested together with the integration test.

[dominikl]

Taking the discussions ome/openmicroscopy#6319 into account:
Instead of the proposed changes, shall I rather remove all calls to joinSession() and use only createSession()? This means all checks if a username is a session id can be removed too. But also implies, that if you want to login with a session id, you have to provide it as username and password. At the moment you only have to provide it as username (same for Insight).

[jburel]

insight has a method joinSession using the gateway method. It does not seem to be used but some changes will be required there too

[dominikl]

It looks like Insight uses it to try to reconnect after a connection loss. Indeed, will need a few changes in Insight too.

[jburel]

I forgot about that