-
Notifications
You must be signed in to change notification settings - Fork 897
Add all Go runtime metrics #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add all Go runtime metrics #997
Conversation
Signed-off-by: dongjiang <dongjiang1989@126.com>
Thanks for the PR! Looking at the docs (and at the metrics that the exporter currently exports), I think thee two are already included in the default registry:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #997 +/- ##
==========================================
- Coverage 80.82% 80.68% -0.14%
==========================================
Files 19 19
Lines 2951 2956 +5
==========================================
Hits 2385 2385
- Misses 456 461 +5
Partials 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 14639048560Details
💛 - Coveralls |
Thanks @oliver006 review Differences:
change to
ref: https://github.com/prometheus/client_golang/blob/main/prometheus/registry.go#L60-L63 |
Thanks for highlighting the diff. What does that effectively mean? What metrics are we getting with that ^^^ that we're currently missing out on. On the one hand I like being explicit about initializing the Registry, on the other hand I like using the DefaultRegistry because it means I'm going with the defaults and if something new is added to the defaults then I'll automagically pull it in when upgrading the client_golang dependency. Thoughts? |
expose all Go runtime metrics like GC stats, memory stats etc.