Move the equality check between a pinned package and its upstream to OpamFile.OPAM.effectively_equal_modulo_pin #6446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l opam file changes while being pinned
…ected and ensure showing local opam files is working as expected
…ages' metadata The reinstall field from the switch state wasn't updated according to the implicit pin and thus opam didn't think there was anything to do.
…OpamFile.OPAM.effectively_equal_modulo_pin
kit-ty-kate
added
AREA: ENGINE
AREA: API
PR: QUEUED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #6209
Queued on #6209
Related to #5907
I think this new function should also be used for regular pins to replace the more simple use of
effectively_equalinopam/src/client/opamPinCommand.ml
Line 562 in 54b91b6
Currently this is a draft, as i'm not sure what is the best interface for this is and thinking about it (on top of #5907 and other possible changes to
OpamFile.OPAMto improve the situation further) will take some time.