Replace relying on variables to generate new templating #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1205 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 260 260
Lines 10870 10870
=======================================
Hits 9536 9536
Misses 915 915
Partials 419 419 ☔ View full report in Codecov by Sentry. |
norkans7
force-pushed
the
variables-params-alt2
branch
from
0548d41 to
ecf7ab0
Compare
norkans7
force-pushed
the
variables-params-alt2
branch
from
ecf7ab0 to
abcf3dd
Compare
norkans7
commented
Jan 17, 2024
| @@ -122,7 +122,18 @@ func (a *SendMsgAction) Execute(run flows.Run, step flows.Step, logModifier flow | |||
| } | |||
|
|
|||
| evaluatedText = translation.Substitute(evaluatedVariables) | |||
| templating = flows.NewMsgTemplating(a.Templating.Template, evaluatedVariables, translation.Namespace()) | |||
|
|
|||
| params := make(map[string][]flows.TemplateParam, 1) | |||
There was a problem hiding this comment.
Just moved building the params here and pass that to the flows.NewMsgTemplating instead of passing a list of variables
norkans7
commented
Jan 17, 2024
| params := make(map[string][]flows.TemplateParam, 1) | ||
|
|
||
| // TODO add support for params in other components besides body | ||
| if len(evaluatedVariables) > 0 { |
There was a problem hiding this comment.
I think here is the right place since we can have access to the param types in the template translations once we support other components and parameter types
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.