Replace flows.MsgTemplating variables by params #1204
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
==========================================
+ Coverage 87.66% 87.73% +0.06%
==========================================
Files 260 260
Lines 10869 10873 +4
==========================================
+ Hits 9528 9539 +11
+ Misses 922 915 -7
Partials 419 419 ☔ View full report in Codecov by Sentry. |
flows/msg.go
Outdated
| @@ -168,28 +168,41 @@ func (m *MsgOut) Locale() i18n.Locale { return m.Locale_ } | |||
| // UnsendableReason returns the reason this message can't be sent (if any) | |||
| func (m *MsgOut) UnsendableReason() UnsendableReason { return m.UnsendableReason_ } | |||
|
|
|||
| type ComponentVariable struct { | |||
There was a problem hiding this comment.
let's call this TemplateParam
There was a problem hiding this comment.
I was trying to make a distinction between that and
type TemplateParam struct {
Type_ string `json:"type"`
}
That we'll use in the template translations
But I just renamed that to TemplateParam
There was a problem hiding this comment.
well they're definitely params now rather than variables...maybe it's ok for them to have same name as they'll be in different packages
norkans7
force-pushed
the
variables-params-alt
branch
from
a388b6d to
25d01c8
Compare
No description provided.