Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing-the-backslash-error #17316

Closed
wants to merge 1 commit into from
Closed

fixing-the-backslash-error #17316

wants to merge 1 commit into from

Conversation

nakul-py
Copy link
Contributor

fixes #17208

Summary of the issue: As same as in #17283

Description of development approach

-> Modify the Markdown source to explicitly escape the backslashes as needed.

-> Use double backslashes in Markdown so the correct output appears in the HTML conversion.
to fix this issue

Testing strategy:

Look at User Guide, paragraph "12.2.2. line no 2298 in Pronuncia de Puntuación y simbolos"

Known issues with pull request: #17208 #17283

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@nakul-py nakul-py requested a review from a team as a code owner October 22, 2024 10:17
@nakul-py nakul-py requested a review from seanbudd October 22, 2024 10:17
@CyrilleB79
Copy link
Collaborator

@nakul-py you do not need to fix non-English .md files. The normal process is that changes are submitted in the English documentation in NVDA's GitHub repo (e.g. #17283). Then translators take care to report the changes done in the English documentation to the translated content; today, it is done through Crowdin. Thus, what you have submitted here will be done by the Aragonese when (and if) they update the User Guide's translation in Crowdin.

Please also note that this PR does not fix #17208; more specifically, it does not address #17208 (comment). You may have misunderstood that comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backslash missing in the User Guide
2 participants